Skip to content

expose several additional constants related to PIRLS thresholds#893

Open
palday wants to merge 3 commits into
mainfrom
pa/expose-tolerances
Open

expose several additional constants related to PIRLS thresholds#893
palday wants to merge 3 commits into
mainfrom
pa/expose-tolerances

Conversation

@palday
Copy link
Copy Markdown
Member

@palday palday commented May 22, 2026

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.65%. Comparing base (e31ae34) to head (2e7f120).

Files with missing lines Patch % Lines
src/generalizedlinearmixedmodel.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files          38       38           
  Lines        3726     3731    +5     
=======================================
+ Hits         3564     3569    +5     
  Misses        162      162           
Flag Coverage Δ
current 95.33% <94.73%> (+<0.01%) ⬆️
minimum 95.54% <94.73%> (-0.05%) ⬇️
nightly 95.33% <94.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dmbates
Copy link
Copy Markdown
Collaborator

dmbates commented Jun 1, 2026

@palday This is a great idea - thank you for making this PR. Do you have any idea why the test on nightly is failing? I don't think the changes here should affect that test.

@palday palday requested a review from dmbates June 3, 2026 05:22
@palday
Copy link
Copy Markdown
Member Author

palday commented Jun 3, 2026

@dmbates As far as I can tell, it was just an intermittent failure on that night's nightly. Everything is working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants