[BUGFIX] Assumption that Ttop of Lineartemp and HalfspaceCoolingTemp is at z=0km#206
Open
ajvanamerongen wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whats the purpose of this PR?
Describe it in more detail below:
The temperature of LinearTemp and HalfspaceCoolingTemp are bugged as they assume that Ttop coincides with z=0, rather than z=z_top_polygon. This results in a shift of temperatures.
Now: T=gradT * z + T0 whereas it should be T=gradT(z - z0) + T0.
A polygon starting at 10 km depth with a thermal gradient of 10C/km and 0C top temperature will have 100C as top temperature rather than 0C.
A representative example of the issue and fix are shown in the two figures below.
Checklist
[BUGFIX],[ADDITION],[DOC], etc.Figure 1.
A subducting slab (left) described as a polygon from z=-12.5 km, with a halfspace cooling thermal profile with Tsurface=0 and thermal age of 80Myr.
A continental plate (right) described as a polygon from z=-12.5 / -8 km (the tapering sedimentary wedge in yellow is part of the plate). It has a linear geotherm from the top at -8 km to -112.5 km of ~ 10C/km.
The white isotherms are 100C, 150C, 350C, 450C and 900C. The 100C and 150C isotherms are practically at the surface although they should be at least several km's lower.
Figure 2.
The improved thermal model using the bugfix. All isotherms are deeper and the 900C isotherm is below the model domain of 80 km (appropriate for a realistic gradient above 10C/km).