Repository navigation
Skip KernelAbstractions' private-memory tests on the LTS stack - #689
Merged
Merged
Conversation
The LTS IGC on Aurora (2.11.29) segfaults compiling KernelAbstractions 0.10's private "in-place" test kernel, which passes a `@private` array to a non-inlined function. IGC's LowerGEPForPrivMem promotes the array to a register even though its address escapes, leaving IR that PrivateMemoryResolution crashes on. IGC 2.22 and later compile it. The testsuite can only skip its private-memory tests as a whole, so skip "Private" when ONEAPI_LTS is set, until ALCF's LTS stack picks up a fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #689 +/- ##
==========================================
- Coverage 81.17% 80.60% -0.58%
==========================================
Files 52 51 -1
Lines 4085 3964 -121
==========================================
- Hits 3316 3195 -121
Misses 769 769 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALCF CI has been failing since the move to KernelAbstractions 0.10 (#653). Both test jobs crash compiling the private-memory "in-place" test kernel (
private.jl:199):The kernel passes a
@privatearray to a@noinlinefunction. Aurora's LTS IGC (2.11.29) promotes that array to a register inLowerGEPForPrivMemeven though its address escapes, andPrivateMemoryResolutionthen crashes on the resulting IR. The bundled IGC (2.34.4) compiles the kernel fine; offline, IGC 2.14 and 2.16 crash and 2.22 does not. A standalone OpenCL C reproducer is being reported to Intel through ALCF.KernelAbstractions' testsuite can only skip its private-memory tests as a whole, so this skips
"Private"whenONEAPI_LTSis set, until the LTS stack on Aurora picks up a fix. The rolling stack (Buildkite) keeps running them.