Skip to content

Require 1.13 tests to pass#798

Open
christiangnrd wants to merge 2 commits into
mainfrom
CI
Open

Require 1.13 tests to pass#798
christiangnrd wants to merge 2 commits into
mainfrom
CI

Conversation

@christiangnrd
Copy link
Copy Markdown
Member

We missed a 1.13 regression introduced in #418 because it's allowed to fail.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metal Benchmarks

Details
Benchmark suite Current: f24d2bc Previous: 356e7d2 Ratio
array/accumulate/Float32/1d 815708 ns 812042 ns 1.00
array/accumulate/Float32/dims=1 980208 ns 997750 ns 0.98
array/accumulate/Float32/dims=1L 10524791 ns 9992916.5 ns 1.05
array/accumulate/Float32/dims=2 1277937.5 ns 1288167 ns 0.99
array/accumulate/Float32/dims=2L 4868833 ns 6890709 ns 0.71
array/accumulate/Int64/1d 979708 ns 980250 ns 1.00
array/accumulate/Int64/dims=1 1109292 ns 1143958 ns 0.97
array/accumulate/Int64/dims=1L 12281521 ns 11832917 ns 1.04
array/accumulate/Int64/dims=2 1456958.5 ns 1472542 ns 0.99
array/accumulate/Int64/dims=2L 9343479 ns 9414375 ns 0.99
array/broadcast 330229.5 ns 366500 ns 0.90
array/construct 5625 ns 5625 ns 1
array/permutedims/2d 623417 ns 632000 ns 0.99
array/permutedims/3d 1127312.5 ns 1132125 ns 1.00
array/permutedims/4d 1356666.5 ns 1993208 ns 0.68
array/private/copy 360958.5 ns 425917 ns 0.85
array/private/copyto!/cpu_to_gpu 240250 ns 365292 ns 0.66
array/private/copyto!/gpu_to_cpu 238000 ns 348750 ns 0.68
array/private/copyto!/gpu_to_gpu 263042 ns 334292 ns 0.79
array/private/iteration/findall/bool 1127625 ns 1070708 ns 1.05
array/private/iteration/findall/int 1283833.5 ns 1248791.5 ns 1.03
array/private/iteration/findfirst/bool 1254833 ns 1218916 ns 1.03
array/private/iteration/findfirst/int 1292583 ns 1359833 ns 0.95
array/private/iteration/findmin/1d 1426542 ns 1455625 ns 0.98
array/private/iteration/findmin/2d 1174042 ns 1214958 ns 0.97
array/private/iteration/logical 1766667 ns 1629542 ns 1.08
array/private/iteration/scalar 1739666 ns 2555500 ns 0.68
array/random/rand/Float32 591395.5 ns 636667 ns 0.93
array/random/rand/Int64 647583 ns 668709 ns 0.97
array/random/rand!/Float32 505041.5 ns 578750 ns 0.87
array/random/rand!/Int64 479666 ns 506833 ns 0.95
array/random/randn/Float32 561791.5 ns 600666.5 ns 0.94
array/random/randn!/Float32 477333 ns 541604.5 ns 0.88
array/reductions/mapreduce/Float32/1d 494500 ns 742292 ns 0.67
array/reductions/mapreduce/Float32/dims=1 461959 ns 499917 ns 0.92
array/reductions/mapreduce/Float32/dims=1L 715375 ns 767083 ns 0.93
array/reductions/mapreduce/Float32/dims=2 463917 ns 497167 ns 0.93
array/reductions/mapreduce/Float32/dims=2L 1033104 ns 1351833 ns 0.76
array/reductions/mapreduce/Int64/1d 808312.5 ns 934291 ns 0.87
array/reductions/mapreduce/Int64/dims=1 767979 ns 794875 ns 0.97
array/reductions/mapreduce/Int64/dims=1L 1225979 ns 1708333.5 ns 0.72
array/reductions/mapreduce/Int64/dims=2 950375 ns 1009417 ns 0.94
array/reductions/mapreduce/Int64/dims=2L 2258709 ns 2261541.5 ns 1.00
array/reductions/reduce/Float32/1d 487958 ns 733437.5 ns 0.67
array/reductions/reduce/Float32/dims=1 458875 ns 497917 ns 0.92
array/reductions/reduce/Float32/dims=1L 716375 ns 817271.5 ns 0.88
array/reductions/reduce/Float32/dims=2 464167 ns 497084 ns 0.93
array/reductions/reduce/Float32/dims=2L 1099604 ns 1350208 ns 0.81
array/reductions/reduce/Int64/1d 793812.5 ns 925375 ns 0.86
array/reductions/reduce/Int64/dims=1 760916.5 ns 793520.5 ns 0.96
array/reductions/reduce/Int64/dims=1L 1215875 ns 1540750 ns 0.79
array/reductions/reduce/Int64/dims=2 961416.5 ns 1054959 ns 0.91
array/reductions/reduce/Int64/dims=2L 2257958 ns 2251625 ns 1.00
array/shared/copy 161208 ns 238167 ns 0.68
array/shared/copyto!/cpu_to_gpu 41084 ns 41375 ns 0.99
array/shared/copyto!/gpu_to_cpu 42208 ns 40000 ns 1.06
array/shared/copyto!/gpu_to_gpu 48500 ns 40458 ns 1.20
array/shared/iteration/findall/bool 1133000 ns 1076916 ns 1.05
array/shared/iteration/findall/int 1292500 ns 1250000 ns 1.03
array/shared/iteration/findfirst/bool 1027500 ns 1078542 ns 0.95
array/shared/iteration/findfirst/int 1069125 ns 1082125 ns 0.99
array/shared/iteration/findmin/1d 1205208 ns 1207709 ns 1.00
array/shared/iteration/findmin/2d 1175625 ns 1221000 ns 0.96
array/shared/iteration/logical 1621209 ns 1469562.5 ns 1.10
array/shared/iteration/scalar 6250 ns 5736 ns 1.09
integration/byval/reference 1174645.5 ns 1158750 ns 1.01
integration/byval/slices=1 1174875 ns 1160375 ns 1.01
integration/byval/slices=2 2122875 ns 2089208 ns 1.02
integration/byval/slices=3 19904250 ns 7773354 ns 2.56
integration/metaldevrt 456209 ns 465584 ns 0.98
kernel/indexing 304708.5 ns 364250 ns 0.84
kernel/indexing_checked 328500 ns 359083 ns 0.91
kernel/launch 13084 ns 13375 ns 0.98
kernel/rand 344750 ns 375625 ns 0.92
latency/import 1409733750 ns 1388543416.5 ns 1.02
latency/precompile 30362520125 ns 30434360354.5 ns 1.00
latency/ttfp 1683611812.5 ns 1654871458 ns 1.02
metal/synchronization/context 843.2727272727273 ns 811.4226804123712 ns 1.04
metal/synchronization/stream 450.75757575757575 ns 427.1356783919598 ns 1.06

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant