Repository navigation
Finalize 0.10: release notes, precompile warnings, compat and CI - #885
Merged
Merged
Conversation
`using .POCL` brought in POCL's `@device_code_*` macros, which clash with KernelAbstractions' own, and POCL's `using LLVM.IR` clashed with its `context`. Import only the names that are used.
KernelInterface 0.3 already had the sub-group ids, `sub_group_barrier` and `shfl_down`; say what 0.4 adds, and that the layout guarantee moved behind `supports_linear_subgroups`. Also fix the `cpu=` option's deprecation version, which said 0.11, and a few typos.
GPUToolbox 3.3.2 requires LLVM 9 or earlier, so with LLVM 10 the effective lower bound was already 3.3.3. TagBot only tagged the root package; add a job for lib/KernelInterface, whose 0.2 and 0.3 releases went untagged.
The back ends' KernelInterface 0.4 support is merged into their default branches, so stop testing the sub-group branches (added temporarily in #831) and the ka-0.10 branches before them.
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Benchmark ResultsShow table
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 28 28
Lines 2454 2454
=======================================
Hits 2027 2027
Misses 427 427 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loose ends before registering KernelInterface 0.4.0 and KernelAbstractions 0.10.0 (both versions are already set on
main).using .POCLbrought POCL's@device_code_*macros into KernelAbstractions, where they clash with its own, and POCL'susing LLVM.IRclashed with POCL'scontext. Both now import only the names they use, and precompiling on 1.10 prints no warnings.sub_group_barrierandshfl_down. It now lists what 0.4 adds and says that the layout guarantee moved behindsupports_linear_subgroups. Also fixes thecpu=docstring, which said the option was deprecated in 0.11, and a few typos.lib/KernelInterface. Its 0.2 and 0.3 releases were never tagged.mainbranches again, replacing the sub-group branches that came in with KernelInterface: sub-group shuffles, votes, reductions and scans #831's[TEMP]commit. The Buildkite jobs here will fail until the back ends' KernelInterface 0.4 PRs are merged.Tested locally on Julia 1.10: KernelAbstractions' test suite passes.
Release notes for the registrations
KernelInterface first:
@JuliaRegistrator register subdir="lib/KernelInterface"Then KernelAbstractions:
@JuliaRegistrator register