Metal: extend address-space inference to integer pointer arguments#819
Merged
Conversation
With typed pointers a Ptr argument crosses a call boundary as an integer (ptrtoint/inttoptr) rather than a generic pointer, so the narrowing pass skipped it; handle that shape too so the deduced exception-name string loads from the constant space on Julia <= 1.11 as it already does on 1.12. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Cover the typed-pointer shape (a Ptr argument crossing as an integer via ptrtoint/inttoptr): assert the parameter narrows to the constant space and callers pass the bare global, plus a negative case where the integer has a non-pointer use and must be left alone. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes #816 work on Julia 1.11.