test: elementwise ops on mismatched sizes throw DimensionMismatch#731
Open
JohnCobbler wants to merge 1 commit into
Open
test: elementwise ops on mismatched sizes throw DimensionMismatch#731JohnCobbler wants to merge 1 commit into
JohnCobbler wants to merge 1 commit into
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding mismatched-size GPU arrays with
+used to silently truncate to theshorter operand (JuliaGPU/CUDA.jl#2812). That path is gone —
+now goesthrough Base
promote_shapeand throwsDimensionMismatchsymmetrically,matching
Base.Array. This adds a guard in the broadcasting testsuite so itstays that way.
The check sits in the parameterized testsuite, so it runs for every backend;
on CPU CI it exercises the same dispatch (the throw happens in
promote_shapebefore any kernel launch), and a CUDA backend confirms the device path.