Repository navigation
Don't wake the log task after its condition is finalized - #3385
Merged
Merged
Conversation
At exit, Julia runs the remaining finalizers newest first, so the AsyncCondition that delivers queued library messages can be finalized before objects whose finalizers still call into a library, e.g. cuDNN descriptors created before `cuDNN.enable_logging()`. When the library then logs, `enqueue_log` passed the condition's null handle to `uv_async_send` and Julia segfaulted. Skip the wake-up instead. Fixes #3379
Contributor
CUDA.jl BenchmarksDetails
This comment was automatically generated by workflow using github-action-benchmark. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At exit, Julia runs the remaining finalizers newest first. The
AsyncConditionthat delivers queued library messages can therefore be finalized before objects whose finalizers still call into a library and make it log, e.g. cuDNN descriptors created beforecuDNN.enable_logging().enqueue_logthen passed the condition's null handle touv_async_sendand Julia segfaulted. Skip the wake-up instead, since nothing can deliver the message at that point.On main this no longer triggers with the reporter's example, because #3318 defers descriptor destruction from finalizers, but any library callback during exit finalization still crashes. The regression test reproduces it with a plain finalizer in a subprocess.
Fixes #3379