Repository navigation
Test Int128 on Julia 1.10/1.11 again - #1139
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
I need to explicitly test on Julia 1.10 and 1.11 to verify the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base.datatype_alignment(Int128) == 16checks from Un-break Int128 axpby! test (fixed by AMDGPU_LLVM_Backend_jll 23.1.1+3) #1127 incore/rocarray_broadcast.jland in the GPUArrayseltypes.Int128 layout matches the hostindevice/launch.jl. It passes a tuple with fields after an Int128 as a kernel argument, and maps over an array of such tuples. With 23.1.1+3 on Julia 1.11 both checks fail. With the fixed back-end they pass.Closes #1002.