Skip to content

Make xmap eager for in memory data by default#583

Merged
meggart merged 4 commits intomainfrom
fc/eagerxmap
Apr 1, 2026
Merged

Make xmap eager for in memory data by default#583
meggart merged 4 commits intomainfrom
fc/eagerxmap

Conversation

@felixcremer
Copy link
Copy Markdown
Member

@felixcremer felixcremer commented Mar 25, 2026

This makes the xmap computation eager by default for in-memory data. This can be changed by setting the Xmap.LAZY_INMEMORY_XMAP constant.
We are using a const here instead of keyword arguments, because we also want to be able to change the behaviour for broadcasts where we can't have a keyword argument.

This closes #579

@felixcremer felixcremer marked this pull request as ready for review March 26, 2026 07:46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.66%. Comparing base (113e035) to head (333a36e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   69.62%   69.66%   +0.04%     
==========================================
  Files          15       15              
  Lines        2199     2202       +3     
==========================================
+ Hits         1531     1534       +3     
  Misses        668      668              
Files with missing lines Coverage Δ
src/DAT/xmap.jl 54.15% <100.00%> (+0.50%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixcremer
Copy link
Copy Markdown
Member Author

Bump

@meggart meggart merged commit d1f920a into main Apr 1, 2026
9 of 11 checks passed
@felixcremer felixcremer deleted the fc/eagerxmap branch April 1, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortcut broadcasting of in memory arrays without going through xmap

2 participants