Fix newly introduced bug when opening Zarr arrays#51
Conversation
|
We should add a test for that. |
776f238 to
2c2db8f
Compare
|
I added a test for that and switched the test data to using esdc. |
|
Any idea where the netcdf-related error is coming from? Is it related to this change? |
|
I don't think it is coming from these changes, because we don't touch the Netcdf path at all. I actually wanted to ask you the same. |
|
@felixcremer Looks like in the test we are trying to store a |
|
Ups. Then I broke the tests by adding to much tests. I think that didn't work in previous versions. Then I broke the tests in #50. |
|
I fixed it and the tests pass locally. I had to do a force-push since I merged master locally. |
bbf0ce2 to
49e0947
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 51.03% 51.44% +0.40%
==========================================
Files 12 12
Lines 482 484 +2
==========================================
+ Hits 246 249 +3
+ Misses 236 235 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The failure on windows nightly and stable seem to be an unrelated downloading time out error which comes from Downloads.download. |
No description provided.