Skip to content

Fix that plot data stays a plain Array #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixcremer wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix that plot data stays a plain Array #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
547f83c
Bump versions
felixcremer Mar 25, 2026
0916a17
Make sure the plot data in the recipe stays a plain Array and is not …
felixcremer Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ Aqua = "0.8"
ArchGDAL = "0.10.4"
CairoMakie = "0.13, 0.14, 0.15"
Colors = "0.12, 0.13"
DimensionalData = "0.28, 0.29"
DiskArrayEngine = "0.1.2, 0.2"
DimensionalData = "0.28, 0.29, 0.30"
DiskArrayEngine = "0.1.2, 0.2, 0.3"
DiskArrayTools = "0.1.10"
DiskArrays = "0.4.2"
Extents = "0.1.3"
Expand Down
9 changes: 5 additions & 4 deletions ext/PyramidSchemeMakieExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,11 @@ function Makie.plot!(plot::Heatmap{<: Tuple{<: Pyramid}})
datalimit = switchkeys(data_limits_ext, pyramid_ext)

if intersects(pyramid_data_ext, data_limits_ext)
# @show data_limits_ext
return (Ref{DD.AbstractDimMatrix}(miss2nan.(
selectlevel(pyramid, datalimit, target_imsize = pixel_widths)
)),)
# This rebuild is necessary because YAXArray broadcast makes the data a DiskArrayEngine type
# This happens also for in-memory arrays see YAXArray issue #579
intersectdata = selectlevel(pyramid, datalimit, target_imsize = pixel_widths)
intersectdata = DD.rebuild(intersectdata, data=miss2nan.(intersectdata.data))
return (Ref{DD.AbstractDimMatrix}(intersectdata),)
else
return nothing # nothing changed so the downstream computation is not marked dirty
end
Expand Down
Loading