Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 89.22% 88.98% -0.24%
==========================================
Files 1 1
Lines 334 336 +2
==========================================
+ Hits 298 299 +1
- Misses 36 37 +1
Continue to review full report at Codecov.
|
Member
|
Good catch, but apparently we need to wait for the result of the discussion at JuliaLang/julia#45125 to know whether this behavior should be supported or not, right? |
Member
Author
|
Right. My assumption is that in JuliaLang/julia#45125 the conclusion will be: propagate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following problem:
Then maybe we also need to add in this PR
method depending on how JuliaLang/julia#45125 is resolved.
CC @nalimilan