Repository navigation
OMNIS-39: Edit TUI text fields by grapheme cluster - #47
Merged
Merged
Conversation
Arrow keys, backspace and delete worked per rune, so one key press hit only part of a combining accent, ZWJ emoji or flag. The cursor now snaps to cluster boundaries; uniseg becomes a direct dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YouTrack: https://youtrack.xn--wrm-hoa.li/issue/OMNIS-39
The TUI filter and option-value fields moved the cursor and deleted per rune, so one key press hit only part of a combining accent, ZWJ emoji or flag. They now work on grapheme clusters.
Changes
editText,pasteTextandeditWindowsnap the cursor to cluster boundaries; left/right/backspace/delete act on whole clusters.posstays a rune index, somodel.goandoptions.goare unchanged.github.com/rivo/unisegbecomes a direct dependency (it was already in the module graph).Test plan
go test ./... -race -count=1,go vet ./...and golangci-lint v2.13.2 pass.e+ U+0301, a ZWJ family emoji and a flag for move, backspace, delete, paste, mid-cluster snap and the scrolled window.omnishell tui, press/and type a combining accent or flag, then check that arrows and backspace treat it as one character.