feat(agents): drop the legacy Conversation/Message model - #82
Merged
Merged
Conversation
Nothing in this workspace calls /api/v1/conversations any more -- agents-ui talks to /api/v1/chat-sessions exclusively -- and no listener was ever registered for ConversationStartedEvent. Drop the model, its ports, jOOQ repos, controller, DTOs, command handlers and query services, and the message/conversation tables (V26). The ArchUnit "command handlers end with CommandHandler" rule matched only on @service, which was unique to the three handlers just removed; every remaining handler is @component, so the rule started checking zero classes and failing outright (ArchUnit's failOnEmptyShould). Match the CommandHandler interface instead of the stereotype so the rule stays live regardless of which annotation a handler carries.
ExtraToast
added
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second of three steps toward moving the renamed Conversation model onto
/api/v1/conversations(#68). Drops the legacy Conversation/Message model entirely: domain classes, ids, statuses, theConversationStartedEvent(no listener consumes it), both ports, the codegen-backed jOOQ repositories, both controllers, their DTOs, command handlers, query services, their tests, and themessageandconversationtables.This is the removal that #81 made possible.
oasdiffraisesapi-path-removed-without-deprecationon a path that disappears, but nothing when the base already marks it deprecated — and #81 put that marker onmain.Validation
:api:test— 594 tests, 592 passed, 0 failed, 2 pre-existing skips:api:integrationTest— 115 tests, 113 passed, 0 failed, 2 skipped--warning-mode=fail— cleanoasdiff breakingagainst the currentorigin/main— no breaking changesThat last line is the whole point of the sequence. The identical removal was flagged before #81 landed.
Notes
/api/v1/conversationsis absent from the service until step three lands. Neitheragents-uinorhome-portalcalls it —agents-uiuses/api/v1/chat-sessionsexclusively — but an undocumented external caller cannot be ruled out from this repo. The endpoints are published in@jorisjonkers-dev/agents-api-client, so worth a glance at real traffic before merging if that is cheap to check.conversationandmessagetables are dropped by migration in FK order. They are separate fromchat_sessions, which step three renames and which keeps all its rows.@Service, an annotation unique to the three deleted handlers; it now matches on theCommandHandlerinterface. ArchUnit'sfailOnEmptyShouldturned that into a hard failure rather than a silent pass, which is how it was caught.Next: #79 rebased onto this — the rename, the ownership fix from #80, and the deprecated
/api/v1/chat-sessionsalias.refs #68