Repository navigation
Fix locale-dependent regex bug in BSR_INSTALL path parsing - #37
Closed
LisanAlGaib-Mahdi wants to merge 2 commits into
Closed
LisanAlGaib-Mahdi wants to merge 2 commits into
LisanAlGaib-Mahdi wants to merge 2 commits into
Conversation
will add fixed one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
-matchto-cmatchfor theBSR_INSTALLregex inResolve-LauncherPaths.On certain regional Windows locales, PowerShell's case-insensitive
-matchconverts the uppercase "I" incorrectly. Because this converted character is not in the[A-Z]range, the regex fails and breaks the root process by returning an empty path.Making it case-sensitive with
-cmatchis a safe, simple fix that solves this issue permanently for all international users without affecting the rest of the script.Note on the commit:
Since
blueStackRoot.cmdis too large to be edited directly via GitHub's web editor, I had to download it, apply the fix locally on my PC, delete the old file from my fork, and upload the modified version. This is why the commit might appear as a full file replacement rather than a simple 1-line edit, but the only actual code change is the-matchto-cmatchmodification.