Repository navigation
Fix disk-format handling and fail fast on host launch errors (#31/#32) - #34
Closed
Jordan231111 wants to merge 13 commits into
Closed
Jordan231111 wants to merge 13 commits into
Jordan231111 wants to merge 13 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigation
Refs #31 and #32 (the two newest open reports). The newer #33 is a closed provenance question without a runtime log and was also reviewed; no provenance/licensing material is changed.
Downloaded and read both complete public attachments:
bsr_debug_20260907_204144.log— 11,590 bytes, SHA256e1f88ad8b0eb4f2eb9cbe037230e4edd96ec25023d3d08cd700b5b069b35213f.bsr_debug_20260913_124341.log— 3,060 bytes, SHA25658638fe119ee6abf755eefadbe8cd6dfbe269f23a291a3ba70baa1c5e81573a2.Both logs fail at line 28 while Windows tries to start
HD-Player.exe, before guest ADB. #31 then polls for 120 seconds with no player or listener; #32's submitted log stops after about 17 seconds with the same absence. The #32 screenshot was also downloaded and reviewed: PREP finishes and detaches the updated disk, then the DATA-stage launch is denied. Removing Defender is not established as a solution; the logs do not identify the denying component.Separately, #31's issue-body transcript reports a virtual-disk provider error during offline Root.vhd attachment. The code inferred storage type from the filename. Microsoft documents this behavior for Mount/Get/Dismount-DiskImage. A VHDX named
.vhdis a reproducible failure case, but the reporter's actual disk format is NOT present in their log and is not assumed to be VHDX.Changes
tools/bsr_host.ps1, embedded into both engines and debug.cmd by reembed.ps1.-ErrorAction Stopindependent of the orchestrator's Continue preference.HOST_LAUNCH_FAILEDand a nonzero status instead of polling an unstarted guest.Validation
Windows validation run 36308106993 passed all six suites: 430 checks passed, 0 failed, 2 existing environment-dependent skips. The new host suite passed 59 checks, including real disposable VHD/VHDX mounts, typed queries, and detach. The old extension-only path failed on a VHDX named
.vhdwith0x80070570; the corrected path succeeded. This reproduces the code defect, not the reporter's exact disk or error code.The two skips require ext4/debugfs tooling and an actual HD-Player executable. Temporary investigation workflows and source patchers have been removed. No release was published and main is unchanged.
Still requires reporter confirmation
Draft because the original Windows permission/policy denial has not been reproduced on the reporters' hosts. These changes fix the demonstrated code paths and diagnostics; they do not grant permissions or bypass host security policy. The existing logs are insufficient to distinguish ACL, AppLocker/App Control, or another host denial. No new ACL/security exclusions or policy changes are made by these helpers.
Please validate the updated diagnostic on Rvc64 (#31) and Tiramisu64 (#32). A remaining host denial should now include native codes and relevant observations; a remaining disk failure should identify the detected format and exact native error. Keep images and backups intact. Do not close either issue on CI results alone.