Multiple enhancements#40
Open
rahal wants to merge 13 commits into
Open
Conversation
rahal
commented
Oct 23, 2022
rahal
commented
- composer file to allow importing as composer vendor
- Added support to type email and url
- Fixed some php notices
- Other small enhancements
…o require vendor outside wordpress Fix Deprecated Optional parameter $active declared before required parameter $force_hidden is implicitly treated as a required parameter
JoeSz
reviewed
Oct 31, 2022
|
|
||
| $args = ( isset( $callback['args'] ) ) ? $callback['args'] : ''; | ||
| $content = call_user_func( $callback['function'], $args ); | ||
| $content .= call_user_func( $callback['function'], $args ); |
Owner
There was a problem hiding this comment.
In fact, it should overwrite, but I can live with this solution too :)
Author
There was a problem hiding this comment.
I needed to have the 'callback' complete the 'content', couldn't find an easier solution :)
Let me know if you like to add this behavior as an option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.