bugfix: Add ? operator for silent errors#2
Open
MoonstarCoding wants to merge 1 commit intoJoeFurfaro:masterfrom
Open
bugfix: Add ? operator for silent errors#2MoonstarCoding wants to merge 1 commit intoJoeFurfaro:masterfrom
? operator for silent errors#2MoonstarCoding wants to merge 1 commit intoJoeFurfaro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event of an incompatible parse due to style, such as
import * as xstatements or the existence of a node_modules folder, the library will throw a silent error in the utils. This is because the value ofspec.importedis not strictly equivalent to the expected value, but is not an object in which contains the required keys that are being requested of it.By adding the
?operator, it at least gives you a stack trace to follow to learn what failed to parse and begin investigating what went wrong.