Repository navigation
Fix Dependabot alerts and update GitHub Actions - #38
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves 14 of the 15 open Dependabot alerts and moves all workflows to the current major versions of their actions. The Node.js 20 deprecation warnings in CI go away as a result.
All alerts are in dev dependencies (
vite/vitest,typedoc,ts-morph); none affect the published package.Dependencies
vite(direct)vitest(direct)@vitest/mocker5.1.0: #55, #56markdown-it(via typedoc)source-map-js(via postcss/vite)brace-expansion(via minimatch)viteis 8.3.6 rather than the latest 8.3.7: 8.3.7 and itsrolldown1.2.18 were published today, so the repo's pnpmminimumReleaseAgepolicy rejects them. 8.3.6 already contains every fix.Not fixed:
minimatch(#58, medium)The fix is only in minimatch 11, which removes APIs.
typedoc0.28.20 (latest) callsMinimatch#matchOne, removed in 11, on every entry point; I tried a pnpm override andtypedoccrashes indiscoverFilesbefore generating docs. Upstream tracks this in TypeStrong/typedoc#3150.Overriding only
ts-morph's copy works (pnpm coveragepasses), but it would not close the alert, because typedoc's copy stays on 10.2.6. I left it out instead of adding an override that changes nothing for the alert.Risk is low: the advisory needs an attacker-controlled glob pattern and
optimizationLevel >= 2. minimatch defaults to1, and the only patterns here are the repo's owntypedoc.jsonentry points andscripts/coverage.tsglobs. The alert can be closed once typedoc supports minimatch 11.Workflows
actions/checkoutactions/setup-nodepnpm/action-setupactions/configure-pagesactions/upload-pages-artifactactions/deploy-pagesBreaking changes in these releases, checked against our usage:
ubuntu-latest(now Ubuntu 26.04) qualifies.packageManagerisnpm; ours ispnpm@11.5.1, so nothing changes. Caching stays explicit (cache: pnpm) in CI, preview, and docs, and stays off inpublish.yml, which setup-node recommends for workflows with elevated privileges.NODE_AUTH_TOKEN.publish.ymluses OIDC trusted publishing and never set a token, so this removes a placeholder that could clash with OIDC.pull_request_target/workflow_run; we use neither..nojekyll. Pages is configured asbuild_type: workflow, so Jekyll never runs and the file isn't needed.packageManager.Also removed a stray blank line in
ci.yml.Verification
actionlintpasses on all workflows.pnpm install --frozen-lockfile,biome ci,type-check,check-doc-examples,pnpm test(111 tests),test:playwright,build,generate-docspass.checkout/pnpm/setup-nodeactions.docs.ymlandpublish.ymlonly run onmainand on tags, so their Pages and publish steps first run after merge and on the next release.