Repository navigation
Add scoped tracing start variants - #37
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #36. Playwright 1.64 made
Tracing.start()andTracing.startChunk()return aDisposablethat stops tracing. #36 dropped it so those wrappers keep succeeding withvoid; this adds the Effect equivalent of disposal.Changes
Tracing.startScoped(options?, stopOptions?): starts tracing and stops it when the currentScopecloses, including on failure or interruption.Tracing.startChunkScoped(options?, stopOptions?): the same for trace chunks.pathare the second argument, since stopping happens in the scope's finalizer. Errors while stopping are logged rather than failing the scope, matching howbrowser.newContextcloses contexts.start()andstartChunk()are unchanged.Verification
src/browser-context.test.ts:startScopedin a failing scope writes the trace and leaves tracing stopped (it can be started again);startChunkScopedwrites the chunk on scope close.Effect.voidmakes thestartScopedtest fail withENOENTon the trace file.pnpm check,pnpm type-check,pnpm test(111 tests), andpnpm check-doc-examplespass.