Fix/restore green build - #30
Merged
Merged
Conversation
The input API changed: set_placeholder now takes window and cx, and set_default_value was removed. Seed the region defaults with set_value instead. Also gets `cargo clippy -- -D warnings` back to clean: - apply cargo fmt to the budget code merged in #23 - allow(dead_code) on the budget API until the UI is wired up (v0.2.0) - use sort_by_key for the SigV4 canonical header sort fmt, clippy, check and test all pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Vendored from longbridge/gpui-component (skills/gpui-component on main): SKILL.md plus the design, coding, usage and style reference guides for the component library this project builds its UI on. Refresh it from the source repo rather than editing in place. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Cargo.toml still asked for 0.5.0-preview1 while the lockfile had already moved to preview2, which is what broke the input API. Move both the manifest and the lockfile onto the 0.5.1 release so they agree. No source changes needed; fmt, clippy, check and test all pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`accent` is a surface token, so using it as the label color painted the selected nav item light grey on light grey. Mirror what the library's own SidebarMenuItem does: sidebar_accent for the background, sidebar_accent_foreground for the label, sidebar_foreground when inactive. Also move the sidebar chrome onto sidebar_border / sidebar_foreground so the whole panel uses one token family. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The About section had 0.1.0 hardcoded; read CARGO_PKG_VERSION instead so it tracks the manifest. AppConfig derived Default, so refresh_interval_minutes came out as 0 and Settings advertised "0 minutes". Give it a real default of 60 and repair configs already written with 0. Nothing schedules a refresh from that value, though, so the Data section only promised behaviour the app does not have. Remove it until the interval is actually wired to something, and say so on the field. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
toggle_dark_mode only wrote the flag to disk; nothing ever called into the theme system, so the switch was inert and the stored preference was never applied. Call Theme::change on toggle, passing the window so it repaints, and apply the saved preference in main() before the first window opens. Drive the switch off the checked value the component hands back instead of flipping our own copy, so the two cannot drift apart. Default to the light theme; the previous dark default had never actually taken effect, so turning the preference on would have changed behaviour for everyone on first launch. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.