Upgrade GPUI Kit 0.7.0 - #6
Merged
Merged
Conversation
Pin the toolkit, shell and component catalog to the v0.7.0 tag and open windows through gpui_kit::open_window instead of hand-wrapping a Root. The hidden export window gets the same Root as the main window, which fixes a panic when a .dash app raises a dialog during export.
Parse DuckDB's LINE n caret position into a UTF-8 byte range and mark it in the editor with a wavy underline and a faint fill, both in the theme's danger color, through v0.7.0's decoration collections. The marks follow edits, stay out of undo history, and clear on the next run. A failed run is captured per tab, so a late answer lands in the tab that asked.
- A pivoted bar spec now draws one grouped chart instead of one small chart per series, scatter draws unconnected points, and a pivoted line draws lines without the borrowed area fill — all hand-built on gpui_kit::base::plot, which v0.7.0 publishes without the styled layer. - Chart tooltips show the formatted value (4.4M) instead of the raw f64, and x labels spread by a width-aware count so date labels no longer collide at the edges. - Result and dashboard tables fit column widths to sampled content, CJK-aware, migrated from docs-onboarding (adds unicode-width). - The title bar and export row compose as Toolbar/ToolbarGroup, gaining arrow-key focus traversal.
EmptyHeader never accepted children: media, title and description are slot methods. The empty state failed to materialize and logged an error every frame the panel showed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the UI toolkit to GPUI Kit v0.7.0 and adopt what it makes possible.
Changes
v0.7.0tag; open windows throughgpui_kit::open_windowinstead of hand-wrapping aRoot. The hidden export window gets the same Root as the main window, fixing a panic when a.dashapp raises a dialog during export.LINE ncaret position into a UTF-8 byte range and mark it in the SQL editor with a wavy underline and faint fill (theme danger color) via v0.7.0's decoration collections. Marks follow edits, stay out of undo history, and clear on the next run.barspec draws one grouped chart instead of one small chart per series,scatterdraws unconnected points, and a pivotedlinedraws lines without the borrowed area fill. Hand-built ongpui_kit::base::plot, which v0.7.0 publishes without the styled component layer. Chart tooltips show the formatted value (4.4M) instead of the raw f64, and x labels spread by a width-aware count so date labels no longer collide at the edges.unicode-width); the title bar and export row compose asToolbar/ToolbarGroup, gaining arrow-key focus traversal.media/title/descriptionslots; the empty state failed to materialize and logged an error every frame.