Release for Linux and Windows too, and build both on every pull request - #4
Merged
Merged
Conversation
The release gains two jobs beside the macOS one: a Linux tarball built on Ubuntu 22.04 (for a glibc old enough for most distributions) with the system libraries gpui-kit's own CI installs, and a Windows zip of ducklocal.exe — unsigned, there being no Windows certificate. The release job waits for all three and publishes all three; a platform that fails fails the release. The locating step now finds each package and checks it is the package, not the artifact archive wrapping it: for the zip, that it holds ducklocal.exe. Neither platform had ever been compiled, so CI builds both on every pull request, before a tag can find out. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release gains two jobs beside the macOS one: a Linux tarball built on Ubuntu 22.04 (for a glibc old enough for most distributions) with the system libraries gpui-kit's own CI installs, and a Windows zip of ducklocal.exe — unsigned, there being no Windows certificate. The release job waits for all three and publishes all three; a platform that fails fails the release.
The locating step now finds each package and checks it is the package, not the artifact archive wrapping it: for the zip, that it holds ducklocal.exe.
Neither platform had ever been compiled, so CI builds both on every pull request, before a tag can find out.