Skip to content

ci: re-render managed files with @j4k/align@1.83.2 - #31

Merged
Jercik merged 1 commit into
mainfrom
ci/re-render-align-1.83.2
Jul 13, 2026
Merged

ci: re-render managed files with @j4k/align@1.83.2#31
Jercik merged 1 commit into
mainfrom
ci/re-render-align-1.83.2

Conversation

@Jercik

@Jercik Jercik commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Re-renders managed files with @j4k/align@1.83.2 (template deltas since the last sweep: tsconfig.test.json type-checks root vitest/vite configs with the new include-reconcile that preserves repo-owned extras; trait-gated ts-reset/dom; vitest/globals gating; nodeTest oxlint layer; css-modules shim gating; baseline fixer preserves feature sublibs).

Changed files:

  • tsconfig.test.json

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach Review: Approach looks good.

The PR adds root-level vitest/vite config files to the test tsconfig's include so they get type-checked. In this project-references setup (tsconfig.json only references tsconfig.app.json and tsconfig.test.json), root-level .ts files aren't covered by either referenced project unless explicitly included — so adding them here is the correct fix. The test config is the right home since it already pulls in vitest/globals types, which these configs depend on.


Approach review by Approach Review 3 (OpenCode Wafer) (GLM-5.2)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach Review: The approach looks good. This is a straightforward automated update to align project configuration with a template, and updating tsconfig.test.json to include the vite/vitest configuration files is the standard way to ensure they are type-checked.


Approach review by Approach Review 2 (gemini-3.1-pro-preview)

@Jercik
Jercik merged commit 692bf27 into main Jul 13, 2026
4 of 8 checks passed
@Jercik
Jercik deleted the ci/re-render-align-1.83.2 branch July 13, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant