Skip to content

Fix Recording Date Serialization Test - #27

Open
spottedmahn wants to merge 2 commits into
JeevanJames:masterfrom
spottedmahn:ratings-lost
Open

Fix Recording Date Serialization Test#27
spottedmahn wants to merge 2 commits into
JeevanJames:masterfrom
spottedmahn:ratings-lost

Conversation

@spottedmahn

Copy link
Copy Markdown

No description provided.

@spottedmahn spottedmahn changed the title Fix Recording Date Serialization Fix Recording Date Serialization Test Dec 3, 2019
@JeevanJames

Copy link
Copy Markdown
Owner

I believe this change does not comply with the ID3 v2.3 spec.

Per the spec, the recording date (TDAT frame) should be in the format DDMM. This frame is complimented by the TYER and TIME frames for the recording year and time.

The only other recording date frame is the TRDA frame (recording dates), but that is a free text frame, so does not need format validation.

Could you clarify the reason behind this change? Are you facing issues with a specific player?

@spottedmahn

Copy link
Copy Markdown
Author

I believe this change does not comply with the ID3 v2.3 spec.

Oh, interesting.

Could you clarify the reason behind this change? Are you facing issues with a specific player?

This test was failing:

public void Serialize_deserialize_test()

@spottedmahn

Copy link
Copy Markdown
Author

image

line 69: Assert.Equal(tag.RecordingDate.Value, clonedTag.RecordingDate.Value);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants