Refactor module and crate responsibility boundaries - #28
Merged
Conversation
Test coverage (lines)Total: 92.39% (-0.32 vs base) — 14931/16161 lines
Files with coverage drops ≥ 1 point
|
JedimEmO
marked this pull request as ready for review
September 5, 2026 10:27
Move the style and script wrapper tags out of the asset files into the assembler so each file is valid CSS, JavaScript, or HTML on its own and whitespace normalization by editors cannot break the served page. Export the configuration placeholder as a constant and use it from both macros. Add unit tests for the placeholder, document structure, and script order. List the crate in the README and changelog. The served explorer differs from before only by one blank line before the closing script tag. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hgg3oKtpBsZ6DC6T1KEnsT
The spec was ignored by the default Playwright config and its CI step had been dropped, leaving the CSS-token regression test manual-only. Run it after the bundle build and upload results on failure. Open and close the task detail panel explicitly in the spec instead of relying on the checkbox click bubbling to the card. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hgg3oKtpBsZ6DC6T1KEnsT
Use ChatServiceClientBuilder from the chat API crate instead of the axum-test ws feature, which had pulled a third tungstenite version into the lockfile. The test now exercises the production client handshake, header auth, and typed dispatch against the real router. Update the refactor record for the explorer and CI follow-ups. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hgg3oKtpBsZ6DC6T1KEnsT
The workspace pinned 0.26 while Axum 0.8 pulled 0.29, so every build carried two copies of tungstenite and tokio-tungstenite. Move the pin to 0.29. No source changes were needed; bidirectional, chat, and WASM client builds and tests pass. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hgg3oKtpBsZ6DC6T1KEnsT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large macro, transport, identity, and example modules mixed parsing, policy, runtime lifecycle, rendering, and tests. This change assigns those responsibilities to focused modules while preserving public import paths, generated APIs, protocol ordering, and serialized output.
ras-api-explorer-assetsas an explicit dependency of both macros. Its source fragments assemble to the original byte-identical HTML.http.All work is in this MR, with each checkpoint verified before the next extraction. See the execution record and accepted plan. Optional demo cleanups and the breaking bidirectional adapter crate move remain deferred.
Validation: hosted workspace tests pass all 927 tests without retries (one existing ignored), plus doctests. Format, Clippy, rustdoc, feature matrix, generated specs, documentation, supply-chain checks, and 11 explorer browser tests pass. Local validation additionally passes the WASM browser task flow, packaged/unpacked macro builds, and exact explorer-byte comparison.
The full local run at default parallelism still intermittently fails in identity/Argon2 tests, including failures observed before refactoring. A fresh build reproduces this; all 927 tests pass locally at four-worker concurrency and in hosted CI without retries. Host/kernel faults were observed, but the cause remains unconfirmed. No skips or crypto changes mask these failures.
Comment-cleanup PR #27 is merged, and this branch includes the updated
master. The diff contains only the refactor work. No workflow changes are included. The additional WASM browser test has a documented local command.