Potential fix for 1 code quality finding#572
Open
tschm wants to merge 3 commits into
Open
Conversation
…py from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…e_variable_overrides.py
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a Makefile-variable override test to avoid asserting behavior based on Makefile include order, aligning the test with higher-level behavioral expectations.
Changes:
- Reworks the
deptryaccumulator test assertions to check for presence of expected fragments (deptry invocation, both folders, andDEP004ignore) instead of a single ordered substring.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+143
to
150
| # Assert behavior, not Makefile include order: both folders must be scanned with DEP004 ignored. | ||
| assert "deptry " in out, "deptry target should invoke deptry; got:\n" + out[:600] | ||
| assert "notebooks" in out and "mypackage" in out, ( | ||
| "deptry should scan both marimo and source folders; got:\n" + out[:600] | ||
| ) | ||
| assert "--ignore DEP004" in out, ( | ||
| "deptry should ignore DEP004 when marimo bundle is enabled; got:\n" + out[:600] | ||
| ) |
…e_variable_overrides.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies 1/1 suggestions from code quality AI findings.