Repository navigation
Harden live CNMV retries and timeout diagnostics - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The September 26 nightly run failed after two CNMV listing read timeouts. This change makes transient failures distinguishable from permanent errors and keeps all smoke-test attempts within the Actions job budget.
Validation: 71 tests passed on Python 3.11 and 3.14 (live test skipped in offline runs); the full live list/download/compare check passed locally in 29.4 seconds. Ruff, compileall, lockfile validation, diff checks, and actionlint passed.
GitHub validation also passed on commit
216fce3: PR checks and manual workflow including real CNMV list/download/compare.Simpler option considered: retain the existing broad
CNMV request failedretry check and only increase its delay.Rejected because: it retries permanent HTTP and filesystem failures; the new deterministic cases verify these fail immediately. Classification at the request boundary also retains exception types when timeout messages are empty, without introducing new exit codes or regex parsing.
Failure investigated: https://github.com/JaviChulvi/cnmv-cli/actions/runs/36274458879