Skip to content

Issue #1: tighten config handling and typed classification payload#2

Open
JasonZhangHub wants to merge 1 commit into
mainfrom
codex/issue-1-config-loading-cleanup
Open

Issue #1: tighten config handling and typed classification payload#2
JasonZhangHub wants to merge 1 commit into
mainfrom
codex/issue-1-config-loading-cleanup

Conversation

@JasonZhangHub
Copy link
Copy Markdown
Owner

Summary

  • simplify load_config() to stop swallowing unrecoverable config errors and use logging for successful loads
  • centralize classification defaults (classification_temperature, classification_max_tokens, output_wrapper_tag) in load_config() so downstream code reads from one place
  • replace the long return tuple annotation in load_classification_data() with a named tuple (ClassificationData)
  • remove duplicated fallback branch in classify_items_with_model() now that defaults are applied at config load

Verification

  • python3 -m py_compile openai_finetuner.py

Closes #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A few suggestions

1 participant