Repository navigation
fix(api): inline @meldrank/rating into the api bundle - #18
Merged
Merged
Conversation
Its package.json has no build output—main/exports point at raw src/index.ts for bundler consumption only. Left external by tsup, the pruned production node_modules resolved that .ts file directly and Node refused to type-strip anything under node_modules (ERR_UNSUPPORTED_NODE_MODULES_TYPE_STRIPPING), crash-looping meldrank-api at boot since the Glicko-2 deploy (v15, Jul 3). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/api/tsup.config.tswas missing@meldrank/ratingfrom itsnoExternallist, so the Glicko-2 PR (Glicko 2 #16) left the import external indist/index.js.@meldrank/rating'spackage.jsonhas no build output —main/exportspoint straight at./src/index.ts, meant for bundler consumption only.node_modulesresolved that raw.tsfile directly, and Node refuses to type-strip anything undernode_modules(ERR_UNSUPPORTED_NODE_MODULES_TYPE_STRIPPING), crash-loopingmeldrank-apiat every boot since thev15deploy (Jul 3, 22:22) — the API has been down for ~4 days.@meldrank/ratingto thenoExternallist so it's inlined like the other internal workspace packages.Already hotfixed in prod: manually rebuilt and
flyctl deployedmeldrank-apiwith this fix ahead of this PR to restore service immediately. This PR lands the fix in git so future CD deploys don't regress.Test plan
pnpm --filter @meldrank/api buildlocally, confirmeddist/index.jsno longer references@meldrank/rating/src(fully inlined)startedstate (previously stuck crash-looping, hit max restart count)401 unauthorizedfor an unauthenticated request, instead of a connection timeout)🤖 Generated with Claude Code