Skip to content

Updated nextflow modules and better configuration#5

Merged
cgoina merged 8 commits into
devfrom
spark-with-conf
Apr 16, 2025
Merged

Updated nextflow modules and better configuration#5
cgoina merged 8 commits into
devfrom
spark-with-conf

Conversation

@cgoina
Copy link
Copy Markdown
Collaborator

@cgoina cgoina commented Apr 16, 2025

@krokicki Improved configuration for spark tasks so that they use the proper container. There are currently 3 pipeline steps that use spark - stitching, spot extraction and multiscale and they all need to use the appropriate container otherwise there may be strange failures. This PR not only updates to the latest spark workflow but it also improved the configuration for stitching and spot extraction

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2025

nf-core pipelines lint overall result: Failed ❌

Posted for pipeline commit 6f562fc

+| ✅ 213 tests passed       |+
#| ❔  11 tests were ignored |#
!| ❗  23 tests had warnings |!
-| ❌  56 tests failed       |-
Details

❌ Test failures:

  • files_exist - File not found: assets/nf-core-easifish_logo_light.png
  • files_exist - File not found: docs/images/nf-core-easifish_logo_light.png
  • files_exist - File not found: docs/images/nf-core-easifish_logo_dark.png
  • files_exist - File must be removed: lib/NfcoreTemplate.groovy
  • files_exist - File must be removed: lib/Utils.groovy
  • files_exist - File must be removed: lib/WorkflowMain.groovy
  • files_exist - File must be removed: lib/nfcore_external_java_deps.jar
  • nextflow_config - Plugin 'nf-validation' does not have a pinned version
  • nextflow_config - Config variable (incorrectly) found: params.max_cpus
  • nextflow_config - Config variable (incorrectly) found: params.max_memory
  • nextflow_config - Config variable (incorrectly) found: params.max_time
  • nextflow_config - Config default value incorrect: params.bigstream_config is set as ${projectDir}/conf/bigstream_config.yml in nextflow_schema.json but is /home/runner/work/easifish/easifish/conf/bigstream_config.yml in nextflow.config.
  • nextflow_config - Config default value incorrect: params.dask_config is set as ${projectDir}/conf/dask_config.yml in nextflow_schema.json but is /home/runner/work/easifish/easifish/conf/dask_config.yml in nextflow.config.
  • nextflow_config - Config default value incorrect: params.local_align_worker_cpus is set as 3 in nextflow_schema.json but is 1 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.bigstream_inv_use_root is set as true in nextflow_schema.json but is false in nextflow.config.
  • nextflow_config - Config default value incorrect: params.multiscale_spark_workers is set as 1 in nextflow_schema.json but is 0 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.multiscale_spark_worker_cores is set as 3 in nextflow_schema.json but is 0 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.multiscale_spark_driver_mem_gb is set as 1 in nextflow_schema.json but is 0 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.cellpose_log_config is set as ${projectDir}/conf/cellpose_logging_config.ini in nextflow_schema.json but is /home/runner/work/easifish/easifish/conf/cellpose_logging_config.ini in nextflow.config.
  • nextflow_config - Config default value incorrect: params.cellpose_dask_config is set as ${projectDir}/conf/dask_config.yml in nextflow_schema.json but is /home/runner/work/easifish/easifish/conf/dask_config.yml in nextflow.config.
  • nextflow_config - Config default value incorrect: params.cellpose_dask_workers is set as 10 in nextflow_schema.json but is 8 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.user_id is set as 0 in nextflow_schema.json but is 1001 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.group_id is set as 0 in nextflow_schema.json but is 118 in nextflow.config.
  • nextflow_config - Config default value incorrect: params.singularity_cache_dir is set as $HOME/.singularity_cache in nextflow_schema.json but is /home/runner/.singularity_cache in nextflow.config.
  • files_unchanged - .github/CONTRIBUTING.md does not match the template
  • files_unchanged - .github/PULL_REQUEST_TEMPLATE.md does not match the template
  • files_unchanged - .github/workflows/branch.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • actions_ci - Minimum pipeline NF version '23.04.0' is not tested in '.github/workflows/ci.yml'
  • schema_params - Param spot_extraction_ids from nextflow config not found in nextflow_schema.json
  • schema_params - Param skip_spot_extraction from nextflow config not found in nextflow_schema.json
  • schema_params - Param distributed_spot_extraction from nextflow config not found in nextflow_schema.json
  • schema_params - Param spot_extraction_subdir from nextflow config not found in nextflow_schema.json
  • schema_params - Param spot_channels from nextflow config not found in nextflow_schema.json
  • schema_params - Param spot_scales from nextflow config not found in nextflow_schema.json
  • schema_params - Param spot_subpaths from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_min_intensity from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_max_intensity from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_anisotropy from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_sigma from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_threshold from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_background from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_intensity from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_spark_workers from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_min_spark_workers from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_spark_worker_cores from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_spark_gb_per_core from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_spark_driver_cores from nextflow config not found in nextflow_schema.json
  • schema_params - Param rsfish_spark_driver_mem_gb from nextflow config not found in nextflow_schema.json
  • schema_params - Param skip_warp_spots from nextflow config not found in nextflow_schema.json
  • schema_params - Param warped_spots_subdir from nextflow config not found in nextflow_schema.json
  • schema_params - Param warp_spots_cpus from nextflow config not found in nextflow_schema.json
  • schema_params - Param warp_spots_mem_in_gb from nextflow config not found in nextflow_schema.json
  • schema_params - Default value for param bigstream_inv_use_root invalid: Schema default (True) does not match the config default (false)
  • modules_json - Your modules.json file is outdated. It will be automatically generated by running any module command.
  • multiqc_config - assets/multiqc_config.yml not found.

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: assets/nf-core-easifish_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-easifish_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-easifish_logo_dark.png
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/easifish/easifish/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.0
  • Run at 2025-04-16 13:46:28

@cgoina cgoina merged commit 6a6afb4 into dev Apr 16, 2025
0 of 8 checks passed
@cgoina cgoina deleted the spark-with-conf branch April 16, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant