This repository was archived by the owner on Mar 9, 2020. It is now read-only.
Fix #428 - #429
Open
yyjdelete wants to merge 1 commit into
Open
Conversation
kangzixiang
approved these changes
Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[] Write a detailed description of your what you have implemented or changed.
-[] Attach unit tests in the testproject to test implemented functionallity.
-[] Make sure no tests fail in the test project.
-[] Verify that you only check in the files intended for the pull request.
-[] Do not change dotnet version, include new dependencies unless you explicitly talked to someone in the project about doing so.
Rebased on the top of 4.5.3.2