Repository navigation
feat(confluence): copy the requested template, and delete storage that is deleted - #245
Merged
Merged
Conversation
copy_file ignored file_id and read one configured page instead, so every executive report and form export was a copy of the incident template. Dispatch resolves a different template per document type and passes it in; which one it is was never the plugin's decision. That configured page was the only reader of `template_id`, so the field goes with it. An existing instance keeps working: the key is simply ignored.
delete_file was never implemented, so delete_storage logged NotImplementedError and the pages stayed. Neither client removes a subtree on its own. Cloud trashes the page it is given and re-parents the children onto their grandparent, leaving an incident's Logs, Screengrabs and documents on the storage root -- observed against a real site, and the reason both paths walk the tree depth-first. Server's remove_page issues its DELETE in advanced mode, which skips raise_for_status, so its own error handling never runs and a refusal arrives as an unread status code. The wrapper reads it and raises.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps the live instance made testable. Stacked on #244 — the diff rests on it and conflicts with
mainalone.copy_fileignoredfile_idand copied one configured page, so every executive report and form export was a copy of the incident template.delete_filewas never implemented, so deleting storage left the pages behind. Neither client removes a subtree: Cloud re-parents the children onto their grandparent, stranding an incident’s sub-pages on the storage root, so both paths now walk the tree.Operators: the unused
template_idfield is gone; no action needed.