Skip to content

fix: make /dispatch-list-incidents arguments and project scoping reachable - #183

Merged
Jamyn merged 1 commit into
mainfrom
fix/133-list-incidents-args-and-project-scope
Aug 18, 2026
Merged

Jamyn merged 1 commit into
mainfrom
fix/133-list-incidents-args-and-project-scope

Conversation

@Jamyn

@Jamyn Jamyn commented Aug 17, 2026

Copy link
Copy Markdown
Owner

The handler split payload["command"] — the command name Slack sends, never the arguments — so the two-element branch was unreachable and a project argument was silently ignored. Arguments now come from payload["text"], unsplit, so a project name containing spaces works; the not-found error reports the request's own organization instead of inventing one from args[0].

Project scoping was equally unreachable: the command carried no subject, so it always read the default organization. A new optional_command_context_middleware resolves the conversation when there is one — adopting both its subject and its session — and falls through outside a channel, where the required variant would have raised.

Closes #133.

@Jamyn Jamyn added the bug Something isn't working label Aug 17, 2026
@Jamyn
Jamyn merged commit 1bd695c into main Aug 18, 2026
13 of 14 checks passed
@Jamyn
Jamyn deleted the fix/133-list-incidents-args-and-project-scope branch August 18, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/dispatch-list-incidents argument parsing and project scoping are both unreachable

1 participant