Repository navigation
fix: load slack project options on demand past the 100-option limit - #138
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack caps
static_selectat 100 options, so a deployment with more than 100 enabled projects could not open Update Incident, Report Incident, Escalate Case or Report Issue at all. Closes #86.project_selectswitches to anexternal_selectserved by a new options-load handler past 100 projects; at or below 100 the payload is unchanged. No project is capped or hidden.display_namediffered fromname; it now resolves by id.Options Load URLto/api/v1/<organization>/events/slack/menu(Interactivity & Shortcuts → Select Menus). It is a separate field from the Request URL; without it the project menu opens empty. Documented inconfiguring-slack.mdx.