Repository navigation
docs: give the three unlinked slack commands their own sections - #136
Merged
Merged
Conversation
Also drops <organization-slug>/<project-slug> from the admin command table: handle_list_incidents_command splits payload["command"], which holds the slash-command name and never the arguments, so that branch is unreachable and the syntax has never worked. handle_report_incident_command reads no arguments at all. Adds onBrokenAnchors: "throw" and a list/section consistency check, run from a new unfiltered docs-checks job so it can later be made a required check.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82.
/dispatch-list-incidents,/dispatch-list-signalsand/dispatch-summarywere listed on the Incident Commander page as plain code spans with no section to link to. Each now has one, written from the handlers rather than from the admin table.The admin table's
<organization-slug>/<project-slug>signatures are removed from/dispatch-list-incidentsand/dispatch-report-incident: slack_bolt only dispatches whenpayload["command"]matches the registered name exactly, so the code reading arguments out of it is unreachable and that syntax has never worked (#133).Guarded by
onBrokenAnchors: "throw"plus a list/section consistency check indocs/scripts, run from a new unfiltereddocs-checksjob — promote it to a required check once it is onmain, which is what makes this blocking rather than advisory.Screenshots deferred to #135; #134 tracks three commands documented nowhere.