Bump microsoft/setup-msbuild from 1.1 to 1.3 - #9
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [microsoft/setup-msbuild](https://github.com/microsoft/setup-msbuild) from 1.1 to 1.3. - [Release notes](https://github.com/microsoft/setup-msbuild/releases) - [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md) - [Commits](microsoft/setup-msbuild@v1.1...v1.3) --- updated-dependencies: - dependency-name: microsoft/setup-msbuild dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Jamiras
pushed a commit
that referenced
this pull request
Sep 7, 2026
…engths input_config_get_bind_string and its joykey/joyaxis helpers accumulate _len from snprintf, strlcpy and fill_pathname_join_delim, all of which return the untruncated length of what they formatted. Once _len passes len, every later "len - _len" size argument underflows to a huge size_t and every "s + _len" write lands past the destination. The reachable producer is menu search: menu_entries_list_search calls menu_entry_get without MENU_ENTRY_FLAG_VALUE_ENABLED, and menu_entry_get still invokes action_get_value (to fill the entry path), passing 0 as the value buffer length. For a bind entry showing an autoconfigured hat bind, "Hat #0 " contributes 7 would-be bytes and the direction 2, so the "(Auto)" suffix snprintf receives (size_t)(0 - 9): FORTIFY: vsnprintf: size 4294967287 > SSIZE_MAX #4 input_config_get_bind_string_joykey+664 #9 menu_entries_list_search observed on the 1.22.2 Play build (armeabi-v7a, Android 12) the moment a user searched a menu containing an auto-bound entry. bionic aborts on the underflowed size; libcs without the check format through it, and the strlcpy segments before it write out of bounds whenever a genuine overshoot (a long autoconf label or localized key name against a small destination) rather than a zero length produced the underflow. Every accumulation point now saturates _len at the last writable byte, and a zero-length destination returns 0 without touching it, matching snprintf's own contract. The clamped value is also what the functions now return, so callers that use the result as an offset no longer inherit the same underflow. Verified with the function bodies extracted verbatim into an ASan canary harness, pre- and post-patch: the exact crash case (len 0, auto hat bind, suffix) returns 16 before and 0 after; truncating cases that returned would-be lengths past the buffer now return the written length; no canary byte is touched in any case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps microsoft/setup-msbuild from 1.1 to 1.3.
Release notes
Sourced from microsoft/setup-msbuild's releases.
Commits
1ff5705Added action-types0e7c76cMerge pull request #110 from Vampire/issue-109 [skip ci]3ac564eImplement #109 adding action types filed3ea839Version bump0a09b7fFixes #104 reassigning input arg [skip ci]0b93bd9Adding arm64 sniffing supportcc48120Merge branch 'master' into arm64645e3f7Modifying version and readme notes [skip ci]1ccd122Fixing formatting on string arg [skip ci]750ad4aDedupe IDs [skip ci]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)