Skip to content

Upgrade for Python 3#61

Open
zevaryx wants to merge 6 commits into
Jahaja:masterfrom
zevaryx:master
Open

Upgrade for Python 3#61
zevaryx wants to merge 6 commits into
Jahaja:masterfrom
zevaryx:master

Conversation

@zevaryx

@zevaryx zevaryx commented Sep 11, 2020

Copy link
Copy Markdown

Upgrade to support Python 3

Drops support for Python 2, but since Python 2 has been deprecated, this should not be an issue

Known Issues

  • UnicodeDecodeError about wrong starting byte when opening some logs
    • Error handling for this error needs added. This wasn't an issue before due to Unicode not being native in Python 2

@Jahaja

Jahaja commented Oct 1, 2020

Copy link
Copy Markdown
Owner

Thanks for the PR. What's the reason for the bootstrap version bump?

@zevaryx

zevaryx commented Oct 2, 2020

Copy link
Copy Markdown
Author

The Bootstrap version bump was due to Flask dropping support for Request.is_xhr, and to bundle all of the required JavaScript in a single file in bootstrap.bundle.min.js for all of the functionality. The bundle file wasn't an option in Bootstrap 3, and is new to Bootstrap 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants