Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Data Transform and Array Loop nodes with Performance Analytics Modal #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Add Data Transform and Array Loop nodes with Performance Analytics Modal #45
Changes from all commits
b041cbfFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Resolve
state.*configuration keys before lookup. The node metadata instructs users to configure keys such asstate.items, but both generators pass that literal string toState.get. SinceStatestoresitems, generated loops read an empty array and generated transforms fall back tostate.last.frontend/src/flow/codegen.ts#L442-L442: normalizeinput_keybefore callingstate.get.frontend/src/flow/codegen.ts#L476-L476: normalizearray_keybefore callingstate.get.frontend/src/flow/codegen.ts#L694-L694: normalizeinput_keybefore callingstate.get.frontend/src/flow/codegen.ts#L719-L719: normalizearray_keybefore callingstate.get.📍 Affects 1 file
frontend/src/flow/codegen.ts#L442-L442(this comment)frontend/src/flow/codegen.ts#L476-L476frontend/src/flow/codegen.ts#L694-L694frontend/src/flow/codegen.ts#L719-L719🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Expand the configured loop item variable. The default
transform_templateuses{{item}}, but each generated loop only callsinterpolate, which supports{{state.<key>}}and does not replace{{item}}. The generated result retains the placeholder instead of the current array item.frontend/src/flow/codegen.ts#L481-L481: replace the configureditem_varplaceholder before JSON parsing.frontend/src/flow/codegen.ts#L724-L724: replace the configureditem_varplaceholder before JSON parsing.📍 Affects 1 file
frontend/src/flow/codegen.ts#L481-L481(this comment)frontend/src/flow/codegen.ts#L724-L724🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Implement
flatten_objectin the JavaScript generator.frontend/src/flow/types.tsexposesflatten_object, and the Python generator implements it. This branch instead parsesexpressionas JSON. A workflow therefore produces different output when generated as JavaScript.Add the same recursive flattening behavior before storing
res.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Implement every runtime transform operation in both code emitters.
runNodesupportsflatten_objectandset_keys. The JavaScript emitter sends both operations through its JSON parse fallback. The Python emitter also sendsset_keysthrough its fallback. Generated workflows therefore produce different results from runtime execution.Add equivalent branches in both emitters. Add parity tests for
flatten_objectandset_keys.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Performance & Scalability | 🟠 Major | ⚡ Quick win
Normalize
max_iterationsbefore slicing the array.parseInt("0", 10) || 100runs 100 iterations instead of zero.parseInt("-1", 10)remains-1, soslice(0, -1)processes every item except the last one. This bypasses the configured iteration bound for large arrays.Clamp valid values to a non-negative integer. Apply the same normalization in both code emitters.
🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.