Add Canvas Theme Selector and Styles #24
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| $ vite --host 0.0.0.0 --port 3000 | ||
|
|
||
| VITE v5.4.21 ready in 298 ms | ||
|
|
||
| ➜ Local: http://localhost:3000/ | ||
| ➜ Network: http://192.168.0.2:3000/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import { describe, it, expect, vi, beforeEach } from "vitest"; | ||
| import React from "react"; | ||
| import { render, screen, fireEvent } from "@testing-library/react"; | ||
| import "@testing-library/jest-dom"; | ||
| import Index from "../pages/Index"; | ||
|
|
||
| // Mock ResizeObserver for ReactFlow in JSDOM | ||
| class MockResizeObserver { | ||
| observe = vi.fn(); | ||
| unobserve = vi.fn(); | ||
| disconnect = vi.fn(); | ||
| } | ||
| global.ResizeObserver = MockResizeObserver; | ||
|
|
||
| describe("Canvas Themes Feature", () => { | ||
| beforeEach(() => { | ||
| // Clean documentElement classes | ||
| document.documentElement.className = ""; | ||
| localStorage.clear(); | ||
| }); | ||
|
|
||
| it("should apply default theme-ice to document.documentElement on initial mount", () => { | ||
| render(<Index />); | ||
|
|
||
| // Default theme should be theme-ice | ||
| expect(document.documentElement.classList.contains("theme-ice")).toBe(true); | ||
| expect(localStorage.getItem("agent_flow.canvas_theme")).toBe("theme-ice"); | ||
| }); | ||
|
|
||
| it("should restore theme from localStorage on mount if saved", () => { | ||
| localStorage.setItem("agent_flow.canvas_theme", "theme-blueprint"); | ||
|
|
||
| render(<Index />); | ||
|
|
||
| // Restored theme should be theme-blueprint | ||
| expect(document.documentElement.classList.contains("theme-blueprint")).toBe(true); | ||
| expect(document.documentElement.classList.contains("theme-ice")).toBe(false); | ||
| }); | ||
|
|
||
| it("should change theme and update document element class and localStorage on selection change", () => { | ||
| render(<Index />); | ||
|
|
||
| // Initially theme-ice | ||
| expect(document.documentElement.classList.contains("theme-ice")).toBe(true); | ||
|
|
||
| const themeSelect = screen.getByTitle("Choose canvas workspace theme"); | ||
| expect(themeSelect).toBeInTheDocument(); | ||
|
|
||
| // Select Retro Amber | ||
| fireEvent.change(themeSelect, { target: { value: "theme-amber" } }); | ||
|
|
||
| // Class list should update | ||
| expect(document.documentElement.classList.contains("theme-amber")).toBe(true); | ||
| expect(document.documentElement.classList.contains("theme-ice")).toBe(false); | ||
|
|
||
| // LocalStorage should update | ||
| expect(localStorage.getItem("agent_flow.canvas_theme")).toBe("theme-amber"); | ||
|
|
||
| // Select Blueprint Grid | ||
| fireEvent.change(themeSelect, { target: { value: "theme-blueprint" } }); | ||
| expect(document.documentElement.classList.contains("theme-blueprint")).toBe(true); | ||
| expect(document.documentElement.classList.contains("theme-amber")).toBe(false); | ||
| expect(localStorage.getItem("agent_flow.canvas_theme")).toBe("theme-blueprint"); | ||
| }); | ||
| }); | ||
|
Comment on lines
+64
to
+65
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Validate the persisted theme before applying it.
localStoragecan contain any string. An unknown value creates a class with no matching theme. A value containing whitespace can makeroot.classList.add(canvasTheme)throw aDOMException. The controlled<select>can also have no matching option.Restrict the value to the four supported theme names and fall back to
"theme-ice". Use the same validation in the change handler. Add a test for invalid stored values.🤖 Prompt for AI Agents