Fail closed on glued Bitwarden refs from bash 0.3.0 refresh - #99
Merged
Merged
Conversation
va refresh on the bash launcher captured each VAR=name:KEY line with $(...), which strips the trailing newline, then concatenated. Launch sent the blob to the vault and reported no secret matched the glued name. validate now rejects that shape and prints the recovered one-mapping-per-line form. refresh splits those lines even when every secret already appears as a substring, so a second merge is not a no-op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
va grokon a host that had run bash 0.3.0va refresh --allfailed with:The rust writer already emits one mapping per line. The reader still treated the glued blob as a legal
name:ref and asked the vault for a secret that does not exist.refreshthen treated everyname:KEYas already mapped because each is a substring of the blob, so a second merge was a no-op.What changed
validate(launch, doctor,secrets validate --offline) fails closed on a gluedVAR=name:VARline and prints the recovered mappings.va refreshsplits those lines even when added == 0.contains.A host still running the 0.3.0 bash binary will re-glue on the next merge refresh.
va updateis the way off that writer.