fix: add missing detected harnesses during va update - #107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users upgrading to Muse support with
va updatereceive the binary but still getunknown harness 'muse', because the old updater leaves Harness configuration untouched. This change makes update ask the newly installed binary to add missing profiles for detected agents, preserving existing profiles and configuration.First-upgrade limitation: updaters shipped through v0.4.23 only replace the binary. After upgrading from one of those versions, users must run
va update --sync-harnessesonce (or repeatva update). Subsequent updates perform both steps in one command. The README, operator instructions, and migration notes document this transition.muse, sova muse --yolopasses through unchanged; Codex retains its native permission defaults.Validation: full
cargo test,cargo fmt --check,cargo clippy --all-targets -- -D warnings, andbash -n install.sh. CLI regressions cover replacement followed by a secrets-injected Muse launch with--yolo, installer/update defaults across all seven profiles, mixed Manifests, file preservation, sudo-user discovery, manager-token scrubbing, and partial failures. Standards and Spec reviews: no remaining findings.Follow-up to #105 and #103.