Repository navigation
Capture Launch directory discovery once per operation - #2015
Open
JacobStephens2 wants to merge 2 commits into
Open
JacobStephens2 wants to merge 2 commits into
JacobStephens2 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One owning-machine operation now shares its crontab, interpreted Cron entries and checkout observations across Launch directory discovery, Cron jobs and Console start choices.
Preserves canonical directory ordering, first-entry output-log precedence, lexical log paths, projection-specific errors, supported Pass validation and scoped transport shapes. The domain-to-code index now locates the capture and its tests.
Closes #2014
Evidence
Execution evidence
Before:
cargo test --test console start_options_share_one_crontab_capture_and_refresh_on_the_next_request -- --exact cronjobs::start_options_share_one_crontab_capture_and_refresh_on_the_next_requestAfter: the same command:
cargo test --bin thirdshift launch_directories::tests: 3 passed.cargo test --test console cronjobs::: 19 passed, including changing captures, shared origin reads, ordering, the error matrix and existing CLI/HTTP parity and scope regressions.cargo test --test console start::submission_captures_fresh_directories_instead_of_trusting_a_start_choice -- --exact: 1 passed.cargo fmt --check: passed.cargo clippy --all-targets -- -D warnings: passed.scripts/affected-tests main: passed. Console: 197 tests passed (268.18 s). Rust: 4,227 tests passed, 97 skipped;cargo nextest runtook 3,131.26 s including compilation (181 s). Complete selection: 3,430.82 s, including builds.Testing seams: the captured Launch directory inventory projections with temporary Git checkouts and fixture executables; the existing CLI/HTTP interface for start-options, local Cron jobs and fresh Command submission. Acquisition counts are observed through the existing crontab/Git command adapters.
Visual evidence
Local Cron jobs with a startable Pickup Pass, 1440 × 900, before and after:
Review coverage
Independent
thirdshift-code-reviewStandards and Spec reviews usedgit diff refs/remotes/origin/main...HEAD(fixed point09f0c6c49e2c056230c38053b8d86a42d9a214f5). Each axis read all 8 changed files. Standards: 0 findings. Spec: 0 findings. Changed files left unread: none. Generated-output exclusions: none. Reports and final files-read lists are saved in.thirdshift-review-5XE7Yr/{standards.md,spec.md,summary.json}in the Session worktree.Unaddressed findings
Standards
None; no findings raised or skipped.
Spec
None; no findings raised or skipped.
Merge Danger
Door: two-way
Internal capture lifetime changes; no persisted-data migration.
Blast Radius: discovery
Shared Launch directory resolution feeds CLI listings, Console repository forms, Cron Pass controls and fresh submission validation.