Fix inherited CI failures on the Quota wait branch

src/logs/recording.rs

@@ -195,7 +195,7 @@ impl<O: Outside> Record<O> {
             self.activity_write(
                 root,
                 &format!("{} warning: {warning}", Kind::UserConfig),
-                Some(History::Kind(Kind::UserConfig)),
+                Some(Kind::UserConfig),
             );
         }
     }
@@ -393,7 +393,7 @@ impl<O: Outside> Record<O> {
         self.activity_write(
             &self.root(repo),
             &format!("{kind} skipped: {reason}"),
-            Some(History::Kind(kind)),
+            Some(kind),
         );
     }
 
@@ -416,7 +416,7 @@ impl<O: Outside> Record<O> {
         } else {
             History::Kind(Kind::Process)
         };
-        self.activity_write(
+        self.activity_write_with_history(
             &root,
             &format!("Process {name} skipped: {reason}"),
             Some(history),
@@ -822,7 +822,16 @@ impl<O: Outside> Record<O> {
         }
     }
 
-    fn activity_write(&mut self, root: &Path, line: &str, unless_last_of: Option<History<'_>>) {
+    fn activity_write(&mut self, root: &Path, line: &str, unless_last_of: Option<Kind>) {
+        self.activity_write_with_history(root, line, unless_last_of.map(History::Kind));
+    }
+
+    fn activity_write_with_history(
+        &mut self,
+        root: &Path,
+        line: &str,
+        unless_last_of: Option<History<'_>>,
+    ) {
         let appended = self.activity_append(&root.join(activity::FILE), line, unless_last_of);
         if let Err(error) = appended
             && !self.activity_warned

tests/console/github.rs

@@ -611,13 +611,12 @@ fn console_and_status_share_both_quota_reserves_and_resume_at_reset() {
         );
         gh["rate_limits"][resource]["remaining"] = json!(5000);
         scenario.write_gh_state(&gh);
+        pr_is(&scenario, "MERGED");
         let mut stream = events(&console);
-        loop {
-            assert!(sse_event(&mut stream).contains("event: commands"));
-            if !console.get("/").text().unwrap().contains(description) {
-                break;
-            }
-        }
+        // The warning expires with the clock; the row moves only after the
+        // background read resumes and observes the merged pull request.
+        wait_for(&console, &mut stream, "resolved");
+        assert!(!console.get("/").text().unwrap().contains(description));
         assert!(scenario.gh_calls_of("api", "graphql").len() >= 2);
         drop(stream);
         drop(console);