Repository navigation
Deepen Cron job interpretation across inventory and Console starts - #2009
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cron jobs, Launch directory discovery and Console starts now obtain their independent facts through one owned interpretation. Existing recognition rules and visible results are preserved.
Adds the Cron job glossary definition, updates the domain-to-code index, and characterizes the same fake crontab through CLI and owning-machine Console projections.
Closes #2008
Evidence
Execution evidence
cargo test --bin thirdshift cronjobs::command::tests::interpretation_preserves_independent_cron_job_factsfailed witherror[E0433]: cannot find type Interpretation in this scopeat the new interface seam.After: the same command passed:
1 passed; 0 failed. The final interpreter suite (cargo test --bin thirdshift cronjobs::command::tests) passed all 3 tests.cargo test --test console cron_job_projections_agree_without_conflating_kind_directory_and_start→1 passed; 0 failed. After caller migration,cargo test --test console cronjobs::passed all 13 tests, including that characterization, Fleet/legacy metadata, scope checks and malformed/display-only entries.cargo check --bin thirdshift,cargo fmt --check, andCARGO_BUILD_JOBS=2 cargo clippy --all-targets -- -D warningspassed.CARGO_BUILD_JOBS=2 NEXTEST_TEST_THREADS=4 RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests main. Site: 68 tests passed (127.82s); Console browser: 197 tests passed (273.31s); full Rust: 4,214 tests passed, 97 skipped. The selector'scargo nextest runtook 2,936.34s, including compilation (2m 36s); total selector wall time was 3,442.21s. The Rust run used four test slots on this host.Test seams
Review coverage
Independent Standards and Spec reviewers each read all seven changed files against
refs/remotes/origin/main, pinned to05171b3c8b80296aed7808c6f93bf5ac7bdf1187. Standards: 0 findings. Spec: 0 findings. Changed files left unread: none on either axis. Generated-output exclusions: none.The complete reports and final files-read lists are retained with the Session trace in
.thirdshift-review-7l1coz/standards.mdand.thirdshift-review-7l1coz/spec.md;summary.jsonrecords{"standards":0,"spec":0}.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
A reversible in-process ownership refactor; no data migration or new execution path.
Blast Radius: Cron
Cron jobs metadata, Launch directory discovery and Console Run now choices share the interpreter. Filesystem checks, supported-Pass matching and request/submission validation remain with their existing owners.
Built with codex codex-cli 0.167.1 · gpt-6.1-sol · xhigh