[JacobStephens2]

Summary

Process and Review runs now honor logs.waiting_line_minutes and the half-silence fallback. Their startup paths already configure logging but bypassed the two entry points that initialized waiting lines, leaving a five-minute default.

logs::configured(config)
  capture effective waiting-line interval (OnceLock: first call wins)
  configure logging

Remove the redundant initialization calls in Ticket and Experiment startup; retain test-minute scaling unchanged.

Closes #1983

Evidence

Execution evidence

• Before: On d7f9f184, cargo test --test ci custom_process_ci_waiting_lines_use_the_configured_interval -- --exact --nocapture failed: expected repeated CI waiting lines, got 1; 0 passed; 1 failed. The copied ticket-run Custom process completed successfully after 14 pending CI observations with logs.waiting_line_minutes = 1 and THIRDSHIFT_WAITING_MINUTE_MS=150.
  After: The same command passed: 1 passed; 0 failed. Centralizing initialization confirms the startup gap as the cause.
• Additional CLI coverage passes for explicit Review and Review --author, Custom process issue startup, and Process Pass/issue host-resource waits. Both explicit intervals and the half-silence fallback repeat lines on stderr with matching counts in the Command log. Existing Ticket and Self-merge heartbeat checks also pass.
• Final validation: CARGO_BUILD_JOBS=2 RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests refs/remotes/origin/main passed: PASS cargo test (4444.68s). Compilation is included; Nextest was unavailable, so the selector used its documented cargo test fallback with three test threads.
• On final commit c9fa1a38, CARGO_BUILD_JOBS=2 RUST_TEST_THREADS=3 cargo test --test ci waiting_lines -- --nocapture passed all three selected tests. cargo fmt --check and CI also passed, including site and Console checks and both Linux artifact builds.

Seams under test

• CLI startup through Custom processes and Review runs (explicit pull request and author Pass), observing unchanged CI waiting lines in stderr and the retained Command log.
• CLI Process Pass startup, observing host-resource waiting lines before its first session.

Review coverage

• Standards: 1 advisory Duplicated Code finding, addressed by sharing the CI heartbeat assertions with the existing Ticket regression. Follow-up confirmed resolution; no remaining findings.
• Spec: 0 findings, including follow-up on the shared assertions.
• Both reviewers read all five changed files. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

• Standards: none.
• Spec: none.
• Security: none.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Blast Radius: logging

Waiting stages now initialize their existing interval at the common logging startup seam. No persistent-data change.

Built with codex codex-cli 0.167.1 · gpt-6.1-sol · xhigh