Repository navigation
Go prototype: embedded skills and supervised Ticket-run session - #1841
Merged
Merged
Conversation
A base-branch checkout can already contain .thirdshift-issue.md as a symlink. The prototype opened that path with truncation and replaced the link's target outside the Worktree, then started the Harness. Refuse the link and keep the regression that plants one at a local canary.
This was referenced Nov 6, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an isolated static Linux Go prototype for the opening half of a Ticket
run. Retains the Worktree for inspection; Delivery, CI Repair and Pickup belong
to later Tickets. Production Rust behavior is unchanged.
Closes #1832
Evidence
Execution evidence
python3 -m unittest scripts.test_affected_tests.AffectedTests.test_go_prototype_only_runs_go_in_its_modulefailed:
[['cargo', 'nextest', 'run']] != [['go', 'test', './...']].After: the same command passes:
Ran 1 test ... OK.go test ./... -run '^TestReviewClaimReleaseRestoresOriginalLabels$' -count=1,failed:
labels = map[enhancement:true ready-for-agent:true], want [enhancement].After: the exact reproduction passed (
ok, 1.530s), and the retainedregression passed again in the Spec follow-up (
ok, 0.932s). Claim endingnow restores only acquisition's label changes.
cd prototype/go && go test -v ./...,go vet ./..., andpython3 bundle-skills.py --checkpass. Tests exercise pre-flight failures,Claim state, real Worktrees, ignored skill links, live streaming, malformed
events, and stubborn Harness/child termination. The ELF test confirms static
linkage from a
CGO_ENABLED=0build.python3 -m unittest discover -s scripts -p 'test_*.py': 37 tests pass.PATH=/usr/local/go/bin:$PATH scripts/affected-tests issue-1830passed:PASS go test ./...andPASS cargo test. The final Go suite and vet werealso rerun after the review fix and passed.
246e3ff3, including the Go prototype,Rust formatting/clippy/tests, site, Console and release artifact builds.
The Console job initially failed the unchanged
signal-lightReady-tagassertion (
Ready must not fall back to Done); one rerun of the failed jobpassed on the same head, with no source changes.
Test seams: the compiled CLI against temporary Git repositories and fake
gh/Claude executables; the affected-test selector CLI against real Git andstand-in runners; the built Linux executable's ELF linkage.
Review coverage
Independent
thirdshift-code-reviewreviews usedissue-1830as the fixedpoint, followed by scoped checks of the fix. Standards: 0 findings.
Spec: 1, reproduced, fixed and retained as a regression; 0 unresolved.
Both axes read every hand-written changed file.
Both intentionally left
prototype/go/factory-skills.jsonunread as generatedoutput. Root
skills/**is unchanged; reviewers read the bundler, embed/linkcode and source examples, confirmed
python3 bundle-skills.py --check, andvalidated actual embedded skill links, supporting-file contents, clean Git
status and static ELF linkage. There are no other unread changed files.
Unaddressed findings
Standards
None.
Spec
None. The single finding was fixed after its exact reproduction failed.
Security
None. The issue-file symlink write was fixed after its proof-of-concept failed, and the regression remains.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: prototype
The isolated Go workflow runs only for prototype/workflow changes. The shared
selector adds a Go area while preserving existing Rust/site/Console selections.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh
CI notes
453fdc70hit its unchanged 10-minute job limit during Playwright dependency installation (Ubuntu mirror: 15.5 MB in 9m58s);npm testnever started. Unrelated to this branch:git diff issue-1830 HEAD -- .github/workflows/ci.yml site/is empty; localnpx playwright install --with-deps chromiumandnpm test --prefix sitepass (67 tests, no skips).