windows: add real app icon#5
Merged
Merged
Conversation
Generate a multi-resolution app.ico (16-256px) from the web shell's brand icon and wire it in two places the unpackaged app needs: - <ApplicationIcon> embeds it in Cascade.exe (Explorer / taskbar / Alt-Tab). - MainWindow sets it via AppWindow.SetIcon for the live window title bar. Previously the app showed the generic default icon. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the generic default icon with the Cascade brand icon (reused from the web shell's
icon-512.png).Assets/app.ico(16/24/32/48/64/128/256px, PNG-compressed, alpha preserved).<ApplicationIcon>embeds it inCascade.exe→ Explorer, taskbar, Alt-Tab.MainWindowcallsAppWindow.SetIcon→ live window title bar.Verified locally: the running window's title bar now shows the brand icon.
🤖 Generated with Claude Code