Repository navigation
ci(metrics): let a full manual Nightly record the rollback count - #459
Merged
Merged
Conversation
A manual run that covers the whole matrix is as complete as a scheduled one, so it publishes. One narrowed to an OS or template is incomplete and now ends quietly instead of failing; a scheduled run still fails loudly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A manual Nightly can narrow the rollback jobs to one OS or template, so #458 kept manual runs from publishing at all. The completeness check already rejects a partial set, so that was blunter than needed: a manual run covering the whole matrix is as complete as a scheduled one and now records, which lets the first point be published before the next scheduled run.
A manual run whose jobs did not all report ends with a notice instead of a failure, since narrowing is deliberate there. A scheduled run that comes up incomplete still fails loudly, so a crashed job is never hidden.